Add deferrable param in BatchOperator#30865
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
syedahsn
suggested changes
Apr 26, 2023
syedahsn
left a comment
syedahsn
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Just need to make a few minor changes.
pankajastro
force-pushed
the
batch_async_op
branch
2 times, most recently
from
a3f47f3 to
dd1286e
Compare
syedahsn
reviewed
Apr 26, 2023
syedahsn
approved these changes
Apr 26, 2023
syedahsn
left a comment
syedahsn
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Nice work!
Member
|
Can we apply the cc: @potiuk |
potiuk
added
the
full tests needed
Member
|
Applied. Closed/reopened to rebuild it. |
vincbeck
approved these changes
May 1, 2023
pankajkoti
reviewed
May 3, 2023
pankajastro
force-pushed
the
batch_async_op
branch
2 times, most recently
from
7073f19 to
3f177d0
Compare
Add the deferrable param in BatchOperator. This will allow running BatchOperator in an async way that means we only submit a job from the worker to run a batch job then defer to the trigger for polling and wait for a job the job status and the worker slot won't be occupied for the whole period of task execution.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
jedcunningham
approved these changes
May 25, 2023
syedahsn
approved these changes
May 25, 2023
syedahsn
left a comment
syedahsn
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Nice work!
2 tasks
2 tasks
86 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the deferrable param in BatchOperator.
This will allow running BatchOperator in an async way
that means we only submit a job from the worker to run a batch job
then defer to the trigger for polling and wait for a job the job status
and the worker slot won't be occupied for the whole period of
task execution.
original PR: #30500
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.