Validate executor and config.core.executor match#30693
Merged
Merged
Conversation
The chart expects the executor to be set in `executor`, however if a user only sets `config.core.executor` it is difficult to diagnose as the chart deploys the wrong rbac resources. This tries to catch that situation.
jedcunningham
force-pushed
the
validate_chart_executor
branch
from
f3e4d57 to
5db9ca9
Compare
potiuk
approved these changes
Apr 22, 2023
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Approve but tests need fixing :)
Member
|
(I re-run just in case). |
Member
|
Ok. It was intermittent. Merging. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart expects the executor to be set in
executor, however if a user only setsconfig.core.executorit is difficult to diagnose as the chart deploys the wrong rbac resources. This tries to catch that situation.