Fix dynamic imports in google ads vendored in library#30544
Merged
Conversation
boring-cyborg
Bot
added
area:dev-tools
area:providers
provider:google
eladkal
approved these changes
Apr 8, 2023
potiuk
force-pushed
the
further-fix-to-googleads-vendoring
branch
from
7a1f530 to
794b50f
Compare
This is a further fix to vendor-in google-ads library: * moving from _vendor to google_vendor is needed to keep the tree structure separate from `google` package used in google provider. If we do not do that, ads library will find "google" package when walking up the tree and will determine that this is the "top" google package * dynamic imports of ads library imports have been updated to also import from the vendored-in library * only v12 version is supported Closes: #30526
potiuk
force-pushed
the
further-fix-to-googleads-vendoring
branch
from
794b50f to
b563385
Compare
16 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 10, 2023
potiuk
added a commit
that referenced
this pull request
Apr 10, 2023
Contributor
|
Just for completeness: I was able to test this and demonstrate that we could use the google secrets manager from the provider and the vendored in package. We got a 503 bad file descriptor error, but I think that's from a syntax difference in the ads API. |
9 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 15, 2023
We've recently added google_venor package to vendor-in ads library, and we had to do it outside of regular google provider package, because internally the library assumed our google package is top level package when discovering the right relative imports (apache#30544). This confused the pre-commit that updates provider depedencies to not recognise the package and print warnings about bad classification. Special case handling will classify it to google provider.
potiuk
added a commit
that referenced
this pull request
Apr 15, 2023
We've recently added google_venor package to vendor-in ads library, and we had to do it outside of regular google provider package, because internally the library assumed our google package is top level package when discovering the right relative imports (#30544). This confused the pre-commit that updates provider depedencies to not recognise the package and print warnings about bad classification. Special case handling will classify it to google provider.
wookiist
pushed a commit
to wookiist/airflow
that referenced
this pull request
Apr 19, 2023
) We've recently added google_venor package to vendor-in ads library, and we had to do it outside of regular google provider package, because internally the library assumed our google package is top level package when discovering the right relative imports (apache#30544). This confused the pre-commit that updates provider depedencies to not recognise the package and print warnings about bad classification. Special case handling will classify it to google provider.
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 21, 2023
We've recently added google_venor package to vendor-in ads library, and we had to do it outside of regular google provider package, because internally the library assumed our google package is top level package when discovering the right relative imports (#30544). This confused the pre-commit that updates provider depedencies to not recognise the package and print warnings about bad classification. Special case handling will classify it to google provider. (cherry picked from commit d87eefc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further fix to vendor-in google-ads library:
moving from _vendor to google_vendor is needed to keep the tree structure separate from
googlepackage used in google provider. If we do not do that, ads library will find "google" package when walking up the tree and will determine that this is the "top" google packagedynamic imports of ads library imports have been updated to also import from the vendored-in library
only v12 version is supported
Closes: #30526
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.