Fix AzureDataFactoryPipelineRunLink UI link generation#30514
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
eladkal
approved these changes
Apr 8, 2023
potiuk
approved these changes
Apr 8, 2023
16 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #30504
In the
extra_linksroute, we are using the methoddag.get_taskto get the task:airflow/airflow/www/views.py
Line 3514 in a9d8ea0
knowing that the dag contains a dict of
SerializedBaseOperatorinstead ofBaseOperator.In
AzureDataFactoryPipelineRunLink, a check on the operator type was added to fix the static checks, but this condition is always False, because the provided operator is an instance ofSerializedBaseOperator. To fix this I just remove the check for now as we do for the other link classes, but we need to refacto all the typing part and the methods signatures.