Remove deferred task from system test#30226
Merged
o-nikolas merged 4 commits intoMar 24, 2023
Merged
Conversation
boring-cyborg
Bot
added
area:providers
area:system-tests
provider:amazon
ferruzzi
reviewed
Mar 21, 2023
phanikumv
reviewed
Mar 22, 2023
vincbeck
approved these changes
Mar 22, 2023
Add resume_cluster option to RedshiftClusterTrigger
syedahsn
force-pushed
the
syedahsn/fix-redshift-system-test-no-defer
branch
from
4cd86a7 to
8161c7d
Compare
o-nikolas
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System tests are not run with a Triggerer Process, which means that deferred tasks are not picked up. I also noticed that there was some missing code from the PR that added deferrable mode to
RedshiftResumeClusterOperator, so I added that in. Please let me know if I missed anything.@phanikumv, @kaxil
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.