Remove replicas if KEDA is enabled

[mabrikan]

Remove replicas field in workers Deployment/StatefulSet if KEDA is enabled

GitOps operators (e.g. ArgoCD) complain when the manifest is changed due to KEDA/HPA auto-scaling. The good practice is to remove replicas field when auto-scaling is used.

Reference:
https://argo-cd.readthedocs.io/en/stable/user-guide/best_practices/#leaving-room-for-imperativeness

[potiuk]

needs static checks fixes and rebase.

[mabrikan]

Done, @potiuk.

[potiuk]

Looks like there are some side-effects of that change - the errors look quite related.

[potiuk]

Nope. It happens in main - we need to fix it there first.

[potiuk]

Can you please rebase @mabrikan -> I think the errors you see should have been fixed in main already, but it's good to double-check it.

[mabrikan]

Sure thing 👍

[potiuk]

Looks good now. And the explanation is plausible. @jedcunningham @dstandish - any problem you see with removing replicas in this case?

[potiuk]

I read a bit more and yeah - that's also official recommendation for HPA to not set replicas, so it should be OK to merge. https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#replicas

@dstandish @jedcunningham - shout if you think otherwise :)