Add deferrable mode to GKEStartPodOperator#29266
Merged
Merged
Conversation
boring-cyborg
Bot
added
provider:cncf-kubernetes
Contributor
Author
kaxil
reviewed
Feb 1, 2023
VladaZakharova
force-pushed
the
gke-def-mode
branch
from
efc9ca6 to
5f0093c
Compare
VladaZakharova
force-pushed
the
gke-def-mode
branch
from
5f0093c to
b040dd4
Compare
VladaZakharova
requested review from
kaxil
and removed request for
jedcunningham
Contributor
Author
|
Hi @kaxil ! |
kaxil
reviewed
Feb 14, 2023
kaxil
reviewed
Feb 14, 2023
VladaZakharova
force-pushed
the
gke-def-mode
branch
from
b040dd4 to
3b8f04d
Compare
VladaZakharova
force-pushed
the
gke-def-mode
branch
2 times, most recently
from
1b5ed97 to
e9d7f94
Compare
Contributor
Author
Contributor
Author
|
@kaxil |
VladaZakharova
requested review from
pankajastro and
phanikumv
and removed request for
pankajastro and
phanikumv
pankajastro
approved these changes
Mar 29, 2023
pankajastro
left a comment
pankajastro
left a comment
Member
There was a problem hiding this comment.
LGTM. But I see the removable of some public methods from the hook so maybe we needs a warning on that for backwards compatibility?
VladaZakharova
force-pushed
the
gke-def-mode
branch
from
215e18b to
deb9b89
Compare
Contributor
Author
|
@pankajastro Could you please review my changes once again? Thanks! :) |
potiuk
approved these changes
Apr 8, 2023
16 tasks
9 tasks
2 tasks
2 tasks
This was referenced Jun 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deferrable mode to GKEStartPodOperator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.