AIP-44 Don't use Internal API in some components#28783
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:CLI
area:dev-tools
area:webserver
Member
|
I guess now we can rebase those :) |
mhenc
force-pushed
the
internal_api_component
branch
from
c08617e to
4e82f9f
Compare
mhenc
force-pushed
the
internal_api_component
branch
3 times, most recently
from
45a7327 to
4cf8c4d
Compare
Contributor
Author
vincbeck
approved these changes
Feb 2, 2023
mhenc
force-pushed
the
internal_api_component
branch
5 times, most recently
from
d440b2c to
592d513
Compare
…using Internal API at all.
mhenc
force-pushed
the
internal_api_component
branch
from
592d513 to
c00d5f8
Compare
potiuk
approved these changes
Feb 14, 2023
Member
|
random mssql failure. |
pierrejeambrun
added
AIP-44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler, Webserver and Internal API components should never use Internal API when calling methods marked with
@internal_api_callbut make direct DB call.closes: #28267