Skip to content

Make secret rendering test more resilient to implementation details #28673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jan 2, 2023
Merged

Make secret rendering test more resilient to implementation details #28673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/www/views/test_views_rendered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from airflow.utils.state import DagRunState, TaskInstanceState
from airflow.utils.types import DagRunType
from tests.test_utils.db import clear_db_dags, clear_db_runs, clear_rendered_ti_fields
from tests.test_utils.www import check_content_in_response
from tests.test_utils.www import check_content_in_response, check_content_not_in_response

DEFAULT_DATE = timezone.datetime(2020, 3, 1)

Expand Down Expand Up @@ -186,7 +186,7 @@ def test_user_defined_filter_and_macros_raise_error(admin_client, create_dag_run
@pytest.mark.usefixtures("patch_app")
def test_rendered_template_secret(admin_client, create_dag_run, task_secret):
"""Test that the Rendered View masks values retrieved from secret variables."""
Variable.set("my_secret", "foo")
Variable.set("my_secret", "secret_unlikely_to_happen_accidentally")
Variable.set("spam", "egg")

assert task_secret.bash_command == "echo {{ var.value.my_secret }} && echo {{ var.value.spam }}"
Expand All @@ -202,8 +202,7 @@ def test_rendered_template_secret(admin_client, create_dag_run, task_secret):
url = f"rendered-templates?task_id=task_secret&dag_id=testdag&execution_date={date}"

resp = admin_client.get(url, follow_redirects=True)
check_content_in_response(
'echo</span> *** <span class="o">&amp;&amp;</span> <span class="nb">echo</span> egg', resp
)
check_content_in_response("***", resp)
check_content_not_in_response("secret_unlikely_to_happen_accidentally", resp)
ti.refresh_from_task(task_secret)
assert ti.state == TaskInstanceState.QUEUED