-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Create Lambda create operator and sensor #28241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING, Any, Sequence | ||
|
|
||
| from airflow.providers.amazon.aws.hooks.lambda_function import LambdaHook | ||
| from airflow.providers.amazon.aws.utils import trim_none_values | ||
|
|
||
| if TYPE_CHECKING: | ||
| from airflow.utils.context import Context | ||
|
|
||
| from airflow.compat.functools import cached_property | ||
| from airflow.exceptions import AirflowException | ||
| from airflow.sensors.base import BaseSensorOperator | ||
|
|
||
|
|
||
| class LambdaFunctionStateSensor(BaseSensorOperator): | ||
| """ | ||
| Asks for the state of the Lambda until it reaches a target state. | ||
| If the query fails, the task will fail. | ||
|
|
||
| .. seealso:: | ||
| For more information on how to use this sensor, take a look at the guide: | ||
| :ref:`howto/sensor:LambdaFunctionStateSensor` | ||
|
|
||
| :param function_name: The name of the AWS Lambda function, version, or alias. | ||
| :param qualifier: Specify a version or alias to get details about a published version of the function. | ||
| :param target_states: The Lambda states desired. | ||
| :param aws_conn_id: aws connection to use, defaults to 'aws_default' | ||
| """ | ||
|
|
||
| FAILURE_STATES = ("Failed",) | ||
|
|
||
| template_fields: Sequence[str] = ( | ||
| "function_name", | ||
| "qualifier", | ||
| ) | ||
|
|
||
| def __init__( | ||
| self, | ||
| *, | ||
| function_name: str, | ||
| qualifier: str | None = None, | ||
| target_states: list = ["Active"], | ||
| aws_conn_id: str = "aws_default", | ||
| **kwargs: Any, | ||
| ) -> None: | ||
| super().__init__(**kwargs) | ||
| self.aws_conn_id = aws_conn_id | ||
| self.function_name = function_name | ||
| self.qualifier = qualifier | ||
| self.target_states = target_states | ||
|
|
||
| def poke(self, context: Context) -> bool: | ||
| get_function_args = { | ||
| "FunctionName": self.function_name, | ||
| "Qualifier": self.qualifier, | ||
| } | ||
| state = self.hook.conn.get_function(**trim_none_values(get_function_args))["Configuration"]["State"] | ||
|
|
||
| if state in self.FAILURE_STATES: | ||
| raise AirflowException( | ||
| "Lambda function state sensor failed because the Lambda is in a failed state" | ||
| ) | ||
|
|
||
| return state in self.target_states | ||
|
|
||
| @cached_property | ||
| def hook(self) -> LambdaHook: | ||
| return LambdaHook(aws_conn_id=self.aws_conn_id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the Aws prefix?
This is not aligned with the convention #20296
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally correct. However, this is not related to this PR, this class existed before this PR, the diff just makes it confusing. I actually dont add
AwsLambdaInvokeFunctionOperatorbutLambdaCreateFunctionOperator.Though, I agree with you, this should be fixed and we should rename it to have something consistent. I just created #29677, I propose a bit more than renaming
AwsLambdaInvokeFunctionOperatortoLambdaInvokeFunctionOperator. Let me know what you think (feel free to comment on the issue)