Skip to content

Rename hook bigquery function _bq_cast to bq_cast#27543

Merged
potiuk merged 4 commits into
apache:mainfrom
astronomer:deprecate_bq_cast
Nov 11, 2022
Merged

Rename hook bigquery function _bq_cast to bq_cast#27543
potiuk merged 4 commits into
apache:mainfrom
astronomer:deprecate_bq_cast

Conversation

@pankajastro

@pankajastro pankajastro commented Nov 7, 2022

Copy link
Copy Markdown
Member

Recently, I have started using hook bigquery function _bq_cast but I'm afraid that this might get changed silently since it is a private function so I want to rename it to bq_cast


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@uranusjr uranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to make this function public, I also wonder if it’d be a good idea to move the function to somewhere in utils instead.

Comment thread airflow/providers/google/cloud/hooks/bigquery.py Outdated
@pankajastro

Copy link
Copy Markdown
Member Author

If we decide to make this function public, I also wonder if it’d be a good idea to move the function to somewhere in utils instead.

I was not able to find the right place to add it to utils. shall I create utils/provider.py or utils/type_cast.py?

@uranusjr

uranusjr commented Nov 9, 2022

Copy link
Copy Markdown
Member

Maybe airflow.providers.google.cloud.utils.bigquery? There’s already a bigquery_get_data so maybe it might make sense in there too…? Not sure.

@pankajastro

Copy link
Copy Markdown
Member Author

Maybe airflow.providers.google.cloud.utils.bigquery? There’s already a bigquery_get_data so maybe it might make sense in there too…? Not sure.

for this PR scope, I'll be in favour of keeping it in airflow.providers.google.cloud.utils.bigquery latter maybe we can also move bigquery_get_data in airflow.providers.google.cloud.utils.bigquery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants