Persist DataprocLink for workflow operators regardless of job status#26986
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
109faea to
948bb2d
Compare
|
Would it be possible to add a test for this? |
c1aa036 to
b76a29d
Compare
|
488e0a3 to
0f97294
Compare
0f97294 to
efcdce7
Compare
For DataprocInstantiateInlineWorkflowTemplateOperator and DataprocInstantiateWorkflowTemplateOperator, the dataproc link is available only for the jobs that have succeeded. Incase of Failure, the DataprocLink is not available
2341fda to
ac8678f
Compare
ac8678f to
38932a9
Compare
|
statuic checks failing. |
It has passed now @potiuk |
|
Nope :( .Static checks are failing. I recommend you to install pre-commit . It will correct the errors for you automatically. |
Done now. Precommit helped! |
Let's see. You are a new user, so I still needed to approve the workflow run from you to run tests. |
|
Anyone from GCP team wants to comment @bjankie1 ? others ? |
Finally, it has passed |
|
Awesome work, congrats on your first merged pull request! |
Fixes #26987
For DataprocInstantiateInlineWorkflowTemplateOperator and DataprocInstantiateWorkflowTemplateOperator, the dataproc link is available only for the jobs that have succeeded. Incase of Failure, the DataprocLink is not available
Also, As we have moved from LOCATION to REGION in dataproc, have renamed the constant in test file to GCP_REGION
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.