-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Change dataprep system tests assets #26488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 5 commits into
apache:main
from
lwyszomi:dataprep_operators_system_test_assets
Nov 10, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ae08ee9
Change dataprep system tests assets
1b27da8
Change logic of base google class, refactor of system test, pre-commi…
d57062e
Docs fix
b85b06a
Fix provider.yaml build issue
c412529
Reformat files with latest black and flake8 config
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
79 changes: 0 additions & 79 deletions
79
airflow/providers/google/cloud/example_dags/example_dataprep.py
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from airflow.providers.google.cloud.links.base import BaseGoogleLink | ||
|
|
||
| if TYPE_CHECKING: | ||
| from airflow.utils.context import Context | ||
|
|
||
| BASE_LINK = "https://clouddataprep.com" | ||
|
MrGeorgeOwl marked this conversation as resolved.
Outdated
|
||
| DATAPREP_FLOW_LINK = BASE_LINK + "/flows/{flow_id}?projectId={project_id}" | ||
| DATAPREP_JOB_GROUP_LINK = BASE_LINK + "/jobs/{job_group_id}?projectId={project_id}" | ||
|
|
||
|
|
||
| class DataprepFlowLink(BaseGoogleLink): | ||
| """Helper class for constructing Dataprep flow link.""" | ||
|
|
||
| name = "Flow details page" | ||
| key = "dataprep_flow_page" | ||
| format_str = DATAPREP_FLOW_LINK | ||
|
|
||
| @staticmethod | ||
| def persist(context: Context, task_instance, project_id: str, flow_id: int): | ||
| task_instance.xcom_push( | ||
| context=context, | ||
| key=DataprepFlowLink.key, | ||
| value={"project_id": project_id, "flow_id": flow_id}, | ||
| ) | ||
|
|
||
|
|
||
| class DataprepJobGroupLink(BaseGoogleLink): | ||
| """Helper class for constructing Dataprep job group link.""" | ||
|
|
||
| name = "Job group details page" | ||
| key = "dataprep_job_group_page" | ||
| format_str = DATAPREP_JOB_GROUP_LINK | ||
|
|
||
| @staticmethod | ||
| def persist(context: Context, task_instance, project_id: str, job_group_id: int): | ||
| task_instance.xcom_push( | ||
| context=context, | ||
| key=DataprepJobGroupLink.key, | ||
| value={ | ||
| "project_id": project_id, | ||
| "job_group_id": job_group_id, | ||
| }, | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.