Skip to content

bugfix: tweak support for project_id argument in BigQueryGetDataOperator #25982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gustavom2998 wants to merge 7 commits into from
Closed

bugfix: tweak support for project_id argument in BigQueryGetDataOperator #25982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d15c38e
tweak BigQueryGetDataOperator project id support
gustavom2998 Aug 26, 2022
a8d51ab
add GetDataOperator no selected fields test and fix code formatting
gustavom2998 Sep 15, 2022
6fc24c9
Merge branch 'main' into main
gustavom2998 Sep 15, 2022
0dd6512
Merge branch 'main' into main
uranusjr Sep 16, 2022
0ec109c
BigQuery Get Data Operator Bug fix - fix static check
gustavom2998 Sep 22, 2022
be533ec
Merge branch 'main' into main
gustavom2998 Sep 22, 2022
8944646
fix BigQueryGetDataOperator static check after merge
gustavom2998 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion airflow/providers/google/cloud/operators/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,10 +893,15 @@ def execute(self, context: Context):

if not self.deferrable:
self.log.info(
'Fetching Data from %s.%s max results: %s', self.dataset_id, self.table_id, self.max_results
'Fetching Data from %s.%s.%s max results: %s',
self.project_id,
self.dataset_id,
self.table_id,
self.max_results,
)
if not self.selected_fields:
schema: dict[str, list] = hook.get_schema(
project_id=self.project_id,
dataset_id=self.dataset_id,
table_id=self.table_id,
)
Expand Down
27 changes: 27 additions & 0 deletions tests/providers/google/cloud/operators/test_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,33 @@ def test_execute(self, mock_hook):
location=TEST_DATASET_LOCATION,
)

@mock.patch('airflow.providers.google.cloud.operators.bigquery.BigQueryHook')
def test_bigquery_getdata_operator_when_no_selected_fields(self, mock_hook):

max_results = 100
operator = BigQueryGetDataOperator(
task_id=TASK_ID,
dataset_id=TEST_DATASET,
table_id=TEST_TABLE_ID,
project_id=TEST_GCP_PROJECT_ID,
max_results=max_results,
location=TEST_DATASET_LOCATION,
)
operator.execute(None)

mock_hook.return_value.get_schema.assert_called_once_with(
project_id=TEST_GCP_PROJECT_ID, dataset_id=TEST_DATASET, table_id=TEST_TABLE_ID
)

mock_hook.return_value.list_rows.assert_called_once_with(
dataset_id=TEST_DATASET,
table_id=TEST_TABLE_ID,
project_id=TEST_GCP_PROJECT_ID,
max_results=max_results,
location=TEST_DATASET_LOCATION,
selected_fields=None,
)


class TestBigQueryTableDeleteOperator(unittest.TestCase):
@mock.patch('airflow.providers.google.cloud.operators.bigquery.BigQueryHook')
Expand Down