Skip to content

Speed up Kubernetes upgrade tests at least 2x #25159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 19, 2022
Merged

Speed up Kubernetes upgrade tests at least 2x #25159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,13 @@ jobs:
all-python-versions-list-as-string: >-
${{ steps.selective-checks.outputs.all-python-versions-list-as-string }}
default-python-version: ${{ steps.selective-checks.outputs.default-python-version }}
min-max-python-versions-as-string: >-
${{ steps.selective-checks.outputs.min-max-python-versions-as-string }}
kubernetes-versions-list-as-string: >-
${{ steps.selective-checks.outputs.kubernetes-versions-list-as-string }}
default-kubernetes-version: ${{ steps.selective-checks.outputs.default-kubernetes-version }}
min-max-kubernetes-versions-as-string: >-
${{ steps.selective-checks.outputs.min-max-kubernetes-versions-as-string }}
postgres-versions: ${{ steps.selective-checks.outputs.postgres-versions }}
default-postgres-version: ${{ steps.selective-checks.outputs.default-postgres-version }}
mysql-versions: ${{ steps.selective-checks.outputs.mysql-versions }}
Expand Down Expand Up @@ -1524,7 +1529,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"

tests-helm-executor-upgrade:
timeout-minutes: 150
name: Helm Chart Executor Upgrade - ${{needs.build-info.outputs.kubernetes-versions-list-as-string}}
name: Helm Chart Executor Upgrade - ${{needs.build-info.outputs.min-max-kubernetes-versions-as-string}}
runs-on: ${{ fromJson(needs.build-info.outputs.runs-on) }}
needs: [build-info, wait-for-prod-images]
env:
Expand All @@ -1536,10 +1541,10 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
EXECUTOR: "KubernetesExecutor"
KIND_VERSION: "${{ needs.build-info.outputs.default-kind-version }}"
HELM_VERSION: "${{ needs.build-info.outputs.default-helm-version }}"
CURRENT_PYTHON_MAJOR_MINOR_VERSIONS_AS_STRING: >
${{needs.build-info.outputs.python-versions-list-as-string}}
CURRENT_KUBERNETES_VERSIONS_AS_STRING: >
${{needs.build-info.outputs.kubernetes-versions-list-as-string}}
CURRENT_PYTHON_MAJOR_MINOR_VERSIONS_AS_STRING: >-
${{needs.build-info.outputs.min-max-python-versions-as-string}}
CURRENT_KUBERNETES_VERSIONS_AS_STRING: >-
${{needs.build-info.outputs.min-max-kubernetes-versions-as-string}}
if: >
needs.build-info.outputs.run-kubernetes-tests == 'true' &&
needs.build-info.outputs.default-branch == 'main'
Expand Down Expand Up @@ -1569,12 +1574,12 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
with:
path: ".build/.kubernetes_venv"
key: "kubernetes-${{ needs.build-info.outputs.default-python-version }}\
-${{needs.build-info.outputs.kubernetes-versions-list-as-string}}
-${{needs.build-info.outputs.python-versions-list-as-string}}
-${{needs.build-info.outputs.min-max-kubernetes-versions-as-string}}
-${{needs.build-info.outputs.min-max-python-versions-as-string}}
-${{ hashFiles('setup.py','setup.cfg') }}"
restore-keys: "kubernetes-${{ needs.build-info.outputs.default-python-version }}-\
-${{needs.build-info.outputs.kubernetes-versions-list-as-string}}
-${{needs.build-info.outputs.python-versions-list-as-string}}"
-${{needs.build-info.outputs.min-max-kubernetes-versions-as-string}} \
-${{needs.build-info.outputs.min-max-python-versions-as-string}}"
- name: "Cache bin folder with tools for kubernetes testing"
uses: actions/cache@v3
with:
Expand Down
16 changes: 16 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,14 @@ def python_versions(self) -> list[str]:
def python_versions_list_as_string(self) -> str:
return " ".join(self.python_versions)

@cached_property
def min_max_python_versions_as_string(self) -> str:
return " ".join(
[CURRENT_PYTHON_MAJOR_MINOR_VERSIONS[0], CURRENT_PYTHON_MAJOR_MINOR_VERSIONS[-1]]
if self._full_tests_needed
else [DEFAULT_PYTHON_MAJOR_MINOR_VERSION]
)

@cached_property
def all_python_versions(self) -> list[str]:
return (
Expand Down Expand Up @@ -380,6 +388,14 @@ def sqlite_exclude(self) -> list[dict[str, str]]:
def kubernetes_versions(self) -> list[str]:
return CURRENT_KUBERNETES_VERSIONS if self._full_tests_needed else [DEFAULT_KUBERNETES_VERSION]

@cached_property
def min_max_kubernetes_versions_as_string(self) -> str:
return " ".join(
[CURRENT_KUBERNETES_VERSIONS[0], CURRENT_KUBERNETES_VERSIONS[-1]]
if self._full_tests_needed
else [DEFAULT_KUBERNETES_VERSION]
)

@cached_property
def kubernetes_versions_list_as_string(self) -> str:
return " ".join(self.kubernetes_versions)
Expand Down