Debounce status highlighting in Grid view#24710
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:UI
Contributor
Author
|
CC: @pierrejeambrun |
Member
|
How does it feel with a delay of 400ms? Did they number come from anywhere particular? |
ashb
approved these changes
Jun 28, 2022
ashb
left a comment
ashb
left a comment
Member
There was a problem hiding this comment.
Code looks fine - only question is if 400ms is too big or too small
Contributor
Author
It's the same delay we already have for Tooltips. Maybe we should make that a single variable across the app? |
Member
|
Nice improvement 👍 |
pierrejeambrun
approved these changes
Jun 28, 2022
Contributor
Author
|
Actually, looks like we weren't consistent with our tooltip delays. I made a |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 30, 2022
* Add delay / debounce to not always highlight tasks * fix linting * single delay variable at 200ms (cherry picked from commit c7feb31)
This was referenced Jul 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, any amount of hovering over a status in grid view will trigger highlighting. Instead, we should make sure the action is intentional by including a debounce with a 200ms delay.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.