Skip to content

Fix deprecated log_id_template value#24506

Merged
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:fix_deprecated_log_id_template
Jun 17, 2022
Merged

Fix deprecated log_id_template value#24506
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:fix_deprecated_log_id_template

Conversation

@jedcunningham

Copy link
Copy Markdown
Member

We had the wrong old default in our deprecated value upgrading logic, so
2.2.5 default wasn't actually being upgraded.

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jun 16, 2022
@jedcunningham jedcunningham added this to the Airflow 2.3.3 milestone Jun 16, 2022
@jedcunningham jedcunningham marked this pull request as ready for review June 16, 2022 19:52

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. That would explain a lot.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 16, 2022
@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We had the wrong old default in our deprecated value upgrading logic, so
2.2.5 default wasn't actually being upgraded.
@jedcunningham jedcunningham force-pushed the fix_deprecated_log_id_template branch from b04282c to 20146c4 Compare June 16, 2022 22:29
@jedcunningham jedcunningham merged commit a955ae4 into apache:main Jun 17, 2022
@jedcunningham jedcunningham deleted the fix_deprecated_log_id_template branch June 17, 2022 01:49
ephraimbuddy pushed a commit that referenced this pull request Jun 29, 2022
We had the wrong old default in our deprecated value upgrading logic, so
the 2.2.5 default wasn't actually being upgraded.

(cherry picked from commit a955ae4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants