Skip to content

[AIRFLOW-1402] Cleanup SafeConfigParser DeprecationWarning - #2435

Closed
ronfung wants to merge 1 commit into
apache:masterfrom
ronfung:work
Closed

[AIRFLOW-1402] Cleanup SafeConfigParser DeprecationWarning#2435
ronfung wants to merge 1 commit into
apache:masterfrom
ronfung:work

Conversation

@ronfung

@ronfung ronfung commented Jul 11, 2017

Copy link
Copy Markdown

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
  • use ConfigParser for python 3.x
    DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser in Python 3.2. This alias will be removed in future versions. Use ConfigParser directly instead.

Tests

  • Test done with ./run_unit_tests.sh on python 2.x and python 3.x pyenv

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io

codecov-io commented Jul 11, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2435 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
- Coverage   69.31%   69.28%   -0.04%     
==========================================
  Files         146      146              
  Lines       11242    11244       +2     
==========================================
- Hits         7792     7790       -2     
- Misses       3450     3454       +4
Impacted Files Coverage Δ
airflow/configuration.py 83.96% <100%> (+0.15%) ⬆️
airflow/jobs.py 75.05% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7159475...07114b9. Read the comment docs.

@criccomini

Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit closed this in 38c86bb Jul 12, 2017
@shahar1 shahar1 mentioned this pull request Jul 10, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants