Skip to content

Maintain grid view selection on filtering upstream #23779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbovenzi merged 2 commits into from
May 19, 2022
Merged

Maintain grid view selection on filtering upstream #23779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8928778
Maintain grid selection on filter upstream
bbovenzi May 18, 2022
64fc670
fix linting
bbovenzi May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/static/js/grid/ResetRoot.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const ResetRoot = () => (
variant="outline"
href={url}
colorScheme="blue"
mr={2}
mx={2}
title="Reset root to show the whole DAG"
>
Reset Root
Expand Down
4 changes: 3 additions & 1 deletion airflow/www/static/js/grid/details/content/taskInstance/Nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const LinkButton = ({ children, ...rest }) => (
);

const Nav = ({
taskId, executionDate, operator, isMapped,
runId, taskId, executionDate, operator, isMapped,
}) => {
const params = new URLSearchParams({
task_id: taskId,
Expand All @@ -68,6 +68,8 @@ const Nav = ({
}).toString();

const filterParams = new URLSearchParams({
task_id: taskId,
dag_run_id: runId,
base_date: baseDate,
num_runs: numRuns,
root: taskId,
Expand Down
1 change: 1 addition & 0 deletions airflow/www/static/js/grid/details/content/taskInstance/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ const TaskInstance = ({ taskId, runId }) => {
{!isGroup && (
<TaskNav
taskId={taskId}
runId={runId}
isMapped={isMapped}
executionDate={executionDate}
operator={operator}
Expand Down