Fix download_media url in GoogleDisplayVideo360SDFtoGCSOperator#22479
Merged
eladkal merged 1 commit intoMar 23, 2022
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
Member
Author
|
@eladkal here is a quick fix for the issue. 😃 |
eladkal
changed the title
download_media url in GoogleDisplayVideo360SDFtoGCSOperator
eladkal
approved these changes
Mar 23, 2022
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
pierrejeambrun
deleted the
14075-wrong-ressource-name-for-google-dv-360-operator
branch
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14075
Following @sarahamilton closed PR and instructions reported in the issue #14075, here is a small change to fix the download url for
Google Display & Video 360service.Link to the API doc: https://developers.google.com/display-video/api/reference/rest/v1/media/download
Link to the underlying lib: https://github.com/googleapis/google-api-python-client/blob/main/googleapiclient/discovery.py
I was not able to create an account on
Google Display & Video 360to test this. (no free trial, or 'fake' account for devs).