Skip to content

Cleanup RedshiftSQLOperator documentation#21976

Merged
potiuk merged 1 commit into
apache:mainfrom
vincbeck:redshift_sql
Mar 7, 2022
Merged

Cleanup RedshiftSQLOperator documentation#21976
potiuk merged 1 commit into
apache:mainfrom
vincbeck:redshift_sql

Conversation

@vincbeck

@vincbeck vincbeck commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Cleanup RedshiftSQLOperator documentation

Comment on lines -18 to -21
"""
This is an example dag for using `RedshiftSQLOperator` to authenticate with Amazon Redshift
then execute a simple select statement
"""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think it's necessary since all files in this directory are example dags. It's kind of obvious. Plus, most of sample dags in this directory do not have a top level comment like this one

@potiuk potiuk merged commit c22fb31 into apache:main Mar 7, 2022
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 7, 2022
@github-actions

github-actions Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants