Skip to content

Add autodetect arg to external table creation in GCS-to-BQ operator#21944

Merged
eladkal merged 4 commits into
apache:mainfrom
shahkshitij15:autodetect_in_external_table_creation
Mar 6, 2022
Merged

Add autodetect arg to external table creation in GCS-to-BQ operator#21944
eladkal merged 4 commits into
apache:mainfrom
shahkshitij15:autodetect_in_external_table_creation

Conversation

@shahkshitij15

@shahkshitij15 shahkshitij15 commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Added autodetect in external table creation for GCS to BQ operator
Now one can create the external table without passing any schema


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@shahkshitij15 shahkshitij15 requested a review from turbaszek as a code owner March 2, 2022 15:50
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Mar 2, 2022
@boring-cyborg

boring-cyborg Bot commented Mar 2, 2022

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr uranusjr changed the title Added autodetect parameter in external table creation using GCS to BQ… Add autodetect arg in external table creation using GCS to BQ operators Mar 3, 2022
@uranusjr uranusjr changed the title Add autodetect arg in external table creation using GCS to BQ operators Add autodetect arg to external table creation in GCS-to-BQ operator Mar 3, 2022
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 3, 2022
@github-actions

github-actions Bot commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk

potiuk commented Mar 3, 2022

Copy link
Copy Markdown
Member

Tests are failing @shahkshitij15

@shahkshitij15

shahkshitij15 commented Mar 3, 2022

Copy link
Copy Markdown
Contributor Author

Hey! I have updated the test cases. Now it should work @potiuk
Please approve @turbaszek

@eladkal eladkal merged commit 9020b3a into apache:main Mar 6, 2022
@boring-cyborg

boring-cyborg Bot commented Mar 6, 2022

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@shahkshitij15

shahkshitij15 commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Hey! With reference to issue #22063, how shall I test the proper working of my code? @potiuk

@potiuk

potiuk commented Mar 8, 2022

Copy link
Copy Markdown
Member

@potiuk

potiuk commented Mar 8, 2022

Copy link
Copy Markdown
Member

Improved instructions added in PR #22087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants