Skip to content

Add test_connection method to AzureDataFactoryHook#21924

Merged
potiuk merged 1 commit into
apache:mainfrom
josh-fell:test-conn-azure-data-factory
Mar 2, 2022
Merged

Add test_connection method to AzureDataFactoryHook#21924
potiuk merged 1 commit into
apache:mainfrom
josh-fell:test-conn-azure-data-factory

Conversation

@josh-fell

Copy link
Copy Markdown
Contributor

Related: #21110

Adding functionality to test an Azure Data Factory connection prior to DAG execution.

Note: This enhancement depends on release of #21330 (currently slated for Airflow 2.3). If there is something else that I should add to this PR to set the minimum Airflow version of the Azure provider, let me know. Not sure if this type of change is handled before or during a provider release or if there some documentation I should also add here. If it's also easier to stash/set this to draft until after 2.3 is released or around its release time, happy to do so.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions

github-actions Bot commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 2, 2022
@potiuk potiuk merged commit f42559a into apache:main Mar 2, 2022
@josh-fell josh-fell deleted the test-conn-azure-data-factory branch March 2, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants