Skip to content

Unpin google-cloud-memcache#21912

Merged
potiuk merged 3 commits into
apache:mainfrom
astronomer:unpin-memchache
Mar 2, 2022
Merged

Unpin google-cloud-memcache#21912
potiuk merged 3 commits into
apache:mainfrom
astronomer:unpin-memchache

Conversation

@kaxil

@kaxil kaxil commented Mar 1, 2022

Copy link
Copy Markdown
Member

This was pinned in July 2021 - https://github.com/apache/airflow/pull/16975/files


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from potiuk March 1, 2022 21:05

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful +1 (let's see the result :))

@github-actions

github-actions Bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 1, 2022
@kaxil kaxil requested a review from turbaszek as a code owner March 1, 2022 21:42
@kaxil kaxil force-pushed the unpin-memchache branch from 3fe9122 to 79fb357 Compare March 1, 2022 22:16
@kaxil kaxil removed the full tests needed We need to run full set of tests for this PR to merge label Mar 1, 2022
Comment thread airflow/providers/google/cloud/operators/cloud_memorystore.py Outdated
@potiuk potiuk merged commit a0e2eba into apache:main Mar 2, 2022
@ephraimbuddy ephraimbuddy deleted the unpin-memchache branch March 2, 2022 10:20
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants