Skip to content

Respect user-configured timezone when generating DAG run ID #21716

Closed
wanlce wants to merge 1 commit into
apache:mainfrom
wanlce:better-display-execution_date
Closed

Respect user-configured timezone when generating DAG run ID #21716
wanlce wants to merge 1 commit into
apache:mainfrom
wanlce:better-display-execution_date

Conversation

@wanlce

@wanlce wanlce commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

The execution date is displayed using the time zone setting instead of
always +00:00.

default_timezone = Asia/Shanghai

before after
2022-02-21_23-53 2022-02-21_23-57

Just better viewing


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The execution date is displayed using the time zone setting instead of
always +00:00.
@uranusjr

Copy link
Copy Markdown
Member

This has much more implications than just the graph view’s UI. See discussions in #17502 and #19039. (also cc @LionelZhao28)

@uranusjr uranusjr changed the title In Graph page execution_date show respect for time zone settings Respect user-configured timezone when generating DAG run ID Feb 22, 2022

@ashb ashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also overrides a dag specific timezone with the global site configured one which is wrong

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 12, 2022
@github-actions github-actions Bot closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants