Replaced hql references to sql in TrinoHook and PrestoHook #21597#21630
Conversation
|
There are 0 files changed.. probably unsuccessful rebase? |
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
LGTM
can you please fix the static checks?
github-actions
Bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
@eladkal, last commit was missing logic to give warning when 'hql' parameter is used, fixed it and static check. |
…documentation.
| """Get a set of records from Presto | ||
| :param sql: SQL statement to be executed. | ||
| :param parameters: The parameters to render the SQL query with. | ||
| """ | ||
| ... |
There was a problem hiding this comment.
| """Get a set of records from Presto | |
| :param sql: SQL statement to be executed. | |
| :param parameters: The parameters to render the SQL query with. | |
| """ | |
| ... | |
| """Get a set of records from Presto. | |
| :param sql: SQL statement to be executed. | |
| :param parameters: The parameters to render the SQL query with. | |
| """ |
One blank line after the first line in the docstring. (See PEP 257)
The ... part is only needed so the function is not empty, but we already have a docstring here and don’t need it.
There was a problem hiding this comment.
Made changes to docstring and also removed ....
3 participants
closes: #21597