Type TaskInstance.task to Operator and call unmap() when needed#21563
Merged
Conversation
uranusjr
requested review from
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
jedcunningham,
kaxil and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:CLI
area:logging
area:providers
area:Scheduler
ashb
approved these changes
Feb 14, 2022
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Feb 14, 2022
Instead of specifically check for -1, this checks the more "logical" distinction between mapped and unmapped tasks: mapped operators always have 0 or positive (since those are the index), while an unmapped task has a negative value.
uranusjr
force-pushed
the
unmapping-taskinstance
branch
from
5122769 to
91bf060
Compare
uranusjr
changed the title
jedcunningham
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I traced all the
TaskInstance.taskcalls I could find (may not be comprehensive but I did what I could), and analysed whethertaskcan be mapped or not on each of their call paths. I added a runtime check when they are guaranteed to be not mapped, and additionalunmapcalls when needed. I also implementedMappedOperator.resourcessince it is needed.This also depends on the
inletsandoutletsproperties proposed in #21495 (right now they are type-ignored so CI can pass).