Skip to content

(AzureCosmosDBHook) Update to latest Cosmos API#21514

Merged
eladkal merged 3 commits into
apache:mainfrom
BenGatewood:azure-cosmos-version-bump
Feb 23, 2022
Merged

(AzureCosmosDBHook) Update to latest Cosmos API#21514
eladkal merged 3 commits into
apache:mainfrom
BenGatewood:azure-cosmos-version-bump

Conversation

@BenGatewood

Copy link
Copy Markdown
Contributor

The AzureCosmosDBHook was still using the API of an older version of the Azure Cosmos SDK. These changes bring it up to date with v4.2.0 of the SDK

closes: #21412

@boring-cyborg

boring-cyborg Bot commented Feb 11, 2022

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk

potiuk commented Feb 15, 2022

Copy link
Copy Markdown
Member

Tests need fixing

@BenGatewood BenGatewood force-pushed the azure-cosmos-version-bump branch 2 times, most recently from a7f9e00 to 871500a Compare February 17, 2022 08:08

@uranusjr uranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for one minor question.

Comment thread airflow/providers/microsoft/azure/hooks/cosmos.py Outdated
@BenGatewood BenGatewood force-pushed the azure-cosmos-version-bump branch from 871500a to 5280457 Compare February 21, 2022 22:59
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 22, 2022
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@josh-fell josh-fell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Now this will actually be usable. Good find and fix @BenGatewood!

@eladkal eladkal merged commit 3c4524b into apache:main Feb 23, 2022
@boring-cyborg

boring-cyborg Bot commented Feb 23, 2022

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@BenGatewood

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.5.0 airflow.providers.microsoft.azure.operators.cosmos not running

5 participants