(AzureCosmosDBHook) Update to latest Cosmos API#21514
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Tests need fixing |
a7f9e00 to
871500a
Compare
uranusjr
left a comment
There was a problem hiding this comment.
Looks good to me except for one minor question.
871500a to
5280457
Compare
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
josh-fell
left a comment
There was a problem hiding this comment.
Nice one! Now this will actually be usable. Good find and fix @BenGatewood!
|
Awesome work, congrats on your first merged pull request! |
|
Thank you! |
The AzureCosmosDBHook was still using the API of an older version of the Azure Cosmos SDK. These changes bring it up to date with v4.2.0 of the SDK
closes: #21412