Skip to content

Task names should be consistent with variable names (drop vs create) in example dags#21434

Merged
eladkal merged 3 commits into
apache:mainfrom
vinooganesh:vinooganesh/fixMinorMySqlOperatorTypo
Feb 19, 2022
Merged

Task names should be consistent with variable names (drop vs create) in example dags#21434
eladkal merged 3 commits into
apache:mainfrom
vinooganesh:vinooganesh/fixMinorMySqlOperatorTypo

Conversation

@vinooganesh

Copy link
Copy Markdown
Contributor

The task names in the MySqlOperator docs currently are not consistent with the actual operations. This PR fixes that.

@boring-cyborg

boring-cyborg Bot commented Feb 8, 2022

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vinooganesh

Copy link
Copy Markdown
Contributor Author

@ashb - I see that you have reviewed similar changes from other folks. Could I please ask you to quickly look this over?

@potiuk

potiuk commented Feb 18, 2022

Copy link
Copy Markdown
Member

Rebased it as it seems that the errors were only "flaky".

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 18, 2022
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr

Copy link
Copy Markdown
Member

Need to fix static checks.

@vinooganesh

Copy link
Copy Markdown
Contributor Author

@uranusjr @potiuk just fixed the static tests, had to force-push because I had some weirdness on my branch. Hope that's okay. If not, I can re-make the PR

@ashb ashb changed the title Task names should be consistent with variable names (drop vs create) Task names should be consistent with variable names (drop vs create) in example dags Feb 18, 2022
@eladkal eladkal merged commit 68da4d8 into apache:main Feb 19, 2022
@boring-cyborg

boring-cyborg Bot commented Feb 19, 2022

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants