Skip to content

FAB still requires WTForms < 3.0#19466

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:pin-wtforms
Nov 8, 2021
Merged

FAB still requires WTForms < 3.0#19466
ashb merged 1 commit into
apache:mainfrom
astronomer:pin-wtforms

Conversation

@ashb

@ashb ashb commented Nov 8, 2021

Copy link
Copy Markdown
Member

Main builds are failing because of this -- for example https://github.com/apache/airflow/runs/4138297504?check_suite_focus=true


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions

github-actions Bot commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 8, 2021
@ashb

ashb commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

Tests getting past the point they were failing at. Merging now.

@ashb ashb merged commit aa15cba into apache:main Nov 8, 2021
@ashb ashb deleted the pin-wtforms branch November 8, 2021 13:35
@potiuk potiuk added this to the Airflow 2.2.2 milestone Nov 8, 2021
@potiuk

potiuk commented Nov 8, 2021

Copy link
Copy Markdown
Member

Added it to 2.2.2 as it should be cherry-picked there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants