Skip to content

Check if job object is None before calling .is_alive()#19380

Merged
uranusjr merged 1 commit into
apache:mainfrom
int3rlop3r:main
Nov 3, 2021
Merged

Check if job object is None before calling .is_alive()#19380
uranusjr merged 1 commit into
apache:mainfrom
int3rlop3r:main

Conversation

@int3rlop3r

Copy link
Copy Markdown
Contributor

The method job_running raises an ArrtibuteError if
the job object passed to is is None. Adding a check
helps fix this (#19365).

The method job_running raises an ArrtibuteError if
the job object passed to is is None. Adding a check
helps fix this.
@boring-cyborg

boring-cyborg Bot commented Nov 3, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 3, 2021
@github-actions

github-actions Bot commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr merged commit 5c15704 into apache:main Nov 3, 2021
@boring-cyborg

boring-cyborg Bot commented Nov 3, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@eladkal eladkal added this to the Airflow 2.2.2 milestone Nov 5, 2021
jedcunningham pushed a commit that referenced this pull request Nov 5, 2021
Co-authored-by: Jonathan Fernandes <jfernandes@virtela.net>
(cherry picked from commit 5c15704)
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants