Fix message on "Mark as" confirmation page#19363
Merged
Merged
Conversation
In an earlier refactor I created a macro called `message` which "stomped" on the variable of the same name set in the view, meaning the page shows `<Macro message>` instead of the string we meant to set. This "fixes" it by using a less-likely-to-clash name for the macro (and fixing the typo in `dismissible` parameter.)
boring-cyborg
Bot
added
area:UI
kaxil
reviewed
Nov 2, 2021
ephraimbuddy
reviewed
Nov 2, 2021
ephraimbuddy
approved these changes
Nov 2, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
okay to merge
jedcunningham
pushed a commit
that referenced
this pull request
Nov 3, 2021
In an earlier refactor I created a macro called `message` which "stomped" on the variable of the same name set in the view, meaning the page shows `<Macro message>` instead of the string we meant to set. This "fixes" it by using a less-likely-to-clash name for the macro (and fixing the typo in `dismissible` parameter.) (cherry picked from commit 2709153)
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an earlier refactor I created a macro called
messagewhich"stomped" on the variable of the same name set in the view, meaning the
page shows
<Macro message>instead of the string we meant to set.This "fixes" it by using a less-likely-to-clash name for the macro (and
fixing the typo in
dismissibleparameter.)