Clarify dag-not-found error message#19338
Merged
jedcunningham merged 2 commits intoNov 1, 2021
Merged
Conversation
In this context, what's really happening is, we can't find the dag. From a user perspective, when you encounter this error, 'could not find the dag' is a more intuitive representation of the problem than 'could not find the dag_id'.
mik-laj
reviewed
Oct 31, 2021
mik-laj
reviewed
Oct 31, 2021
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
jedcunningham
approved these changes
Nov 1, 2021
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
pushed a commit
that referenced
this pull request
Nov 3, 2021
In this context, what's really happening is, we can't find the dag. From a user perspective, when you encounter this error, 'could not find the dag' is a more intuitive representation of the problem than 'could not find the dag_id'. (cherry picked from commit 0be26b4)
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this context, what's really happening is, we can't find the dag. From a user
perspective, when you encounter this error, 'could not find the dag' is
a more intuitive representation of the problem than 'could not find the dag_id'.