Added sas_token var to BlobServiceClient return. Updated tests#19234
Merged
ephraimbuddy merged 2 commits intoOct 27, 2021
Conversation
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
ephraimbuddy
approved these changes
Oct 27, 2021
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are unable to pass the full URI for the
sas_tokenargument in an Azure Blob connection. This is because theextra.get('extra__wasb__sas_token')was not being passed to theBlobServiceClientif it began withhttps.These changes resolve this, and extend the tests for all 4 cases to check if the token was attached to the URI.