Skip to content

Fix Toggle Wrap on DAG code page#19211

Merged
ashb merged 6 commits into
apache:mainfrom
PApostol:fix-toggle-wrap-code-button
Nov 3, 2021
Merged

Fix Toggle Wrap on DAG code page#19211
ashb merged 6 commits into
apache:mainfrom
PApostol:fix-toggle-wrap-code-button

Conversation

@PApostol

Copy link
Copy Markdown
Contributor

Closes #17047

Root of issue: ToggleWrap function was undefined.

After applying the changes (see line 31):

  • Before clicking Toggle Wrap :
    before

  • After clicking Toggle Wrap :
    after

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 25, 2021
Comment thread airflow/www/static/js/dag_code.js

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 25, 2021
@uranusjr

Copy link
Copy Markdown
Member

How does [webserver] default_wrap get passed to the frontend after this change? I thought that's what the wrapped meta value is for. Now it does not seem to be used anywhere? See Airflow.code in views.py.

@PApostol

Copy link
Copy Markdown
Contributor Author

How does [webserver] default_wrap get passed to the frontend after this change? I thought that's what the wrapped meta value is for. Now it does not seem to be used anywhere? See Airflow.code in views.py.

That's a good point, I must have missed that. I've added the isWrapped meta value back - otherwise the default_wrap value won't be used.

Comment thread airflow/www/templates/airflow/dag_code.html
@uranusjr uranusjr requested a review from bbovenzi October 27, 2021 00:16
Comment thread airflow/www/static/js/dag_code.js Outdated
@eladkal eladkal added this to the Airflow 2.2.2 milestone Oct 27, 2021
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
@PApostol

PApostol commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

Hi, is there anything else required for this PR?

@ashb ashb merged commit a1632ed into apache:main Nov 3, 2021
@PApostol PApostol deleted the fix-toggle-wrap-code-button branch November 3, 2021 14:25
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Nov 3, 2021
jedcunningham pushed a commit that referenced this pull request Nov 3, 2021
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
(cherry picked from commit a1632ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle Wrap on DAG code page is broken

6 participants