Add test_connection method for Snowflake Hook#19041
Conversation
|
I kind of feel like this is reinventing exceptions. It actually looks a lot like the Result monad in some languages, or Go's result, err = hook.test_connection()
if result:
... # Success.
else:
print(f"failed with {err}")becomes try:
hook.check_connection()
except ConnectionFailure as e:
print(f"failed with {e}")
else:
... # Success. |
Make sense.. modified the code.. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.