Handle leading slash in samba path#18847
Merged
potiuk merged 1 commit intoOct 9, 2021
Merged
Conversation
uranusjr
reviewed
Oct 9, 2021
Fix issue that occurs when the path to a file on a samba share has a slash prepended to it, then the `SambaHook` will treat the path as the host instead likely resulting trying to connect to the wrong samba host.
fredthomsen
force-pushed
the
sambaHandleLeadingSlashInPath
branch
from
October 9, 2021 11:53
56e0e62 to
e37872c
Compare
uranusjr
approved these changes
Oct 9, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Oct 9, 2021
54 tasks
91 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue that occurs when the path to a file on a samba share has a
slash prepended to it, then the
SambaHookwill treat the path as thehost instead likely resulting trying to connect to the wrong samba host.
For example, this code:
resulted in:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.