Add SalesforceApexRestOperator#18819
Merged
Merged
Conversation
uranusjr
requested changes
Oct 8, 2021
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
I don't unsderstand Salesforce to say anything about the operator logic, so a comment on Python code in general.
uranusjr
approved these changes
Oct 8, 2021
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
Again, can't comment on the actual operator, but the usage lgtm 🙂
github-actions
Bot
added
the
okay to merge
uranusjr
removed
the
okay to merge
Contributor
Author
|
I'm checking the docs to pass on tests |
eladkal
self-requested a review
October 8, 2021 03:17
potiuk
approved these changes
Oct 8, 2021
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM. Nice to see examples, howtos etc. ! Good job.
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SalesforceApexRestOperator, this operator allows to call Apex rest methods
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.