Skip to content

Add standard hook fields to pagerdutyHook to make hook show up in UI#18763

Merged
potiuk merged 3 commits into
apache:mainfrom
GuidoTournois:pagerduty
Oct 7, 2021
Merged

Add standard hook fields to pagerdutyHook to make hook show up in UI#18763
potiuk merged 3 commits into
apache:mainfrom
GuidoTournois:pagerduty

Conversation

@GuidoTournois

Copy link
Copy Markdown
Contributor

Pagerduty is not shown as a Connection type in the Connection view. That is because of two reasons:

  1. The PagerdutyHook class is not added in the provider.yaml, nor in the field connection-types, nor in the soon to be deprecated field hook-class-names. This PR fixes this.
  2. Even after fixing 1, the hooks could not be added as some required fields were missing: conn_name_attr, default_conn_name, conn_type, hook_name. This PR adds those.

closes: #18748

@boring-cyborg

boring-cyborg Bot commented Oct 6, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Comment thread airflow/providers/pagerduty/provider.yaml Outdated
@GuidoTournois
GuidoTournois requested a review from uranusjr October 7, 2021 07:26
@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 7, 2021
@potiuk
potiuk merged commit 39359b9 into apache:main Oct 7, 2021
@boring-cyborg

boring-cyborg Bot commented Oct 7, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagerduty connection type not showing in up ConnectionModelView

4 participants