Update BigQueryCreateExternalTableOperator doc and parameters#18676
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
github-actions
Bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
| if not bucket: | ||
| raise ValueError("`bucket` is required when not using `table_resource`.") | ||
| if not source_objects: | ||
| raise ValueError("`source_objects` is required when not using `table_resource`.") |
There was a problem hiding this comment.
I think ValueError is more correct.
Passing arguments of the wrong type (e.g. passing a list when an int is expected) should result in a TypeError, but passing arguments with the wrong value (e.g. a number outside expected boundaries) should result in a ValueError.
This case is more of "wrong arguments" not "arguments types".
There was a problem hiding this comment.
Agree with Tomek. Value error is good here.
|
Reopened to rebuild |
|
Static checks failing |
|
can someone with write access review and close this pr? thanks |
5 participants
Update parameter to reflect expected usage while maintaining backwards compatibility.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.