Expanding docs on client auth for AzureKeyVaultBackend#18659
Merged
Conversation
boring-cyborg
Bot
added
area:providers
area:secrets
kind:documentation
provider:microsoft-azure
alexbegg
force-pushed
the
azure-key-vault-backend
branch
from
October 1, 2021 00:19
4fe891b to
de95423
Compare
uranusjr
approved these changes
Oct 3, 2021
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Oct 3, 2021
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the documentation on client authentication for
AzureKeyVaultBackendusing Azure Python SDK'sDefaultAzureCredentialclass. Added an example of adding environment variables to use the service principal with secret.Also, carried over the note about client authentication form the docs page into the python file's docstring (this is what is used to populate Astronomer' Registry site, so without this change their soccumentation is missing notes about client authentication).
Also included a link to the
DefaultAzureCredentialclass reference page.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.