Add missing __init__.py files for some test packages#18142
Merged
Conversation
Lacl of the __init__.py caused failures in some specific cases - especially when new providers have been added. This PR adds missing ``__init__.py`` files and modifies pre-commit check which was only implemented for main files and example_dags. It checks if those files are present and adds them if missing.
boring-cyborg
Bot
added
area:dev-tools
area:providers
area:secrets
provider:amazon
Merged
ashb
approved these changes
Sep 10, 2021
ashb
left a comment
ashb
left a comment
Member
There was a problem hiding this comment.
At time's the ASF insistence on having the copyright notice in every file, even otherwise blank ones is mildly annoying 😁
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lacl of the init.py caused failures in some specific
cases - especially when new providers have been added.
This PR adds missing
__init__.pyfiles and modifies pre-commitcheck which was only implemented for main files and
example_dags. It checks if those files are present and adds them if
missing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.