Always upgrade to newer dependencies in main#17939
Merged
uranusjr merged 1 commit intoAug 31, 2021
Merged
Conversation
When we want to run the "push" or "schedule" build, we want to always "upgrade to newer dependencies" because we want to attempt to generate latest constraints. There was a mistake that caused failures like celery incompatibilities because successfull main build pushed downgraded constraints because the released image did not contain latest celery libraries and it has not been rebuilt with latest constraints yet.
Member
Author
|
This was the root cause of the problems like https://github.com/apache/airflow/pull/17935/checks?check_run_id=3471093531#step:10:5138 which happened recently from time to time. The problem was that successful build in main could actually "Downgrade" the constraints in some cases where cached image contained still celery 4.7. This one should fix it - all the "main" (push/schedule) builds will use the "eager upgrade" and the generated constraints will never be downgraded to the last cache. |
eladkal
approved these changes
Aug 31, 2021
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 1, 2021
The apache#17939 did not fix the problem finally. It turned out that one more change was needed - since we now always upgrade to latest dependencies in `push` and `schedule` type of build we do not need to check for the variable UPGRADE_TO_NEWER_DEPENDENCIES (which was not set in "Build Image" step. This fixes it, but also changes the constraint generation to add comments in the generated constraint files, describing how and why the files are generated.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 2, 2021
The apache#17939 did not fix the problem finally. It turned out that one more change was needed - since we now always upgrade to latest dependencies in `push` and `schedule` type of build we do not need to check for the variable UPGRADE_TO_NEWER_DEPENDENCIES (which was not set in "Build Image" step. This fixes it, but also changes the constraint generation to add comments in the generated constraint files, describing how and why the files are generated.
potiuk
added a commit
that referenced
this pull request
Sep 2, 2021
The #17939 did not fix the problem finally. It turned out that one more change was needed - since we now always upgrade to latest dependencies in `push` and `schedule` type of build we do not need to check for the variable UPGRADE_TO_NEWER_DEPENDENCIES (which was not set in "Build Image" step. This fixes it, but also changes the constraint generation to add comments in the generated constraint files, describing how and why the files are generated.
potiuk
added a commit
that referenced
this pull request
Sep 2, 2021
The #17939 did not fix the problem finally. It turned out that one more change was needed - since we now always upgrade to latest dependencies in `push` and `schedule` type of build we do not need to check for the variable UPGRADE_TO_NEWER_DEPENDENCIES (which was not set in "Build Image" step. This fixes it, but also changes the constraint generation to add comments in the generated constraint files, describing how and why the files are generated. (cherry picked from commit bec006e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we want to run the "push" or "schedule" build, we want
to always "upgrade to newer dependencies" because we want to
attempt to generate latest constraints.
There was a mistake that caused failures like celery
incompatibilities because successfull main build pushed downgraded
constraints because the released image did not contain latest
celery libraries and it has not been rebuilt with latest
constraints yet.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.