deduplicate running jobs on BigQueryInsertJobOperator#17496
Merged
Conversation
uranusjr
approved these changes
Aug 9, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
Following test is failing, can you fix it please @blcksrx |
Contributor
Author
|
@kaxil Thanks for noticing, it was an stupid error on unit-test side, I fixed it but unfortunately CI failed because of some conflict in installing packages that is unrelated to this PR. |
turbaszek
approved these changes
Aug 31, 2021
Contributor
|
@blcksrx can you please rebase - it will probably solve the CI problems |
1ee15f0 to
cc1e838
Compare
Contributor
Author
|
@eladkal Thanks man |
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
job.resultmethod already invokes on thehook.insert_jobmethod, so basically it's duplicated beside of the referenced issue.airflow/airflow/providers/google/cloud/hooks/bigquery.py
Lines 1639 to 1641 in ef1b124
In addition, In my opinion, the
insert_jobmethod should only responsible to inserting a job not verifying the job is completed and wait for it.related: #17493