Skip to content

Fix error mount temporary directory when using DockerOperator #17230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nguyenmphu wants to merge 1 commit into from
Closed

Fix error mount temporary directory when using DockerOperator #17230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions airflow/providers/docker/operators/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,33 +248,25 @@ def _run_image(self) -> Optional[str]:
raise Exception("The 'cli' should be initialized before!")
if self.mount_tmp_dir:
with TemporaryDirectory(prefix='airflowtmp', dir=self.host_tmp_dir) as host_tmp_dir_generated:
tmp_mount = Mount(self.tmp_dir, host_tmp_dir_generated, "bind")
try:
return self._run_image_with_mounts(self.mounts + [tmp_mount], add_tmp_variable=True)
except APIError as e:
if host_tmp_dir_generated in str(e):
self.log.warning(
"Using remote engine or docker-in-docker and mounting temporary "
"volume from host is not supported. Falling back to "
"`mount_tmp_dir=False` mode. You can set `mount_tmp_dir` parameter"
" to False to disable mounting and remove the warning"
)
return self._run_image_with_mounts(self.mounts, add_tmp_variable=False)
raise
return self._run_image_with_mounts(self.mounts, add_tmp_variable=False,
tmp_mount_dir=host_tmp_dir_generated)
else:
return self._run_image_with_mounts(self.mounts, add_tmp_variable=False)

def _run_image_with_mounts(self, target_mounts, add_tmp_variable: bool) -> Optional[str]:
def _run_image_with_mounts(self, target_mounts, add_tmp_variable: bool,
tmp_mount_dir: Optional[str] = None) -> Optional[str]:
if add_tmp_variable:
self.environment['AIRFLOW_TMP_DIR'] = self.tmp_dir
else:
self.environment.pop('AIRFLOW_TMP_DIR', None)
volumes = [f"{tmp_mount_dir}:{self.tmp_dir}"] if tmp_mount_dir else []
self.container = self.cli.create_container(
command=self.format_command(self.command),
name=self.container_name,
environment={**self.environment, **self._private_environment},
host_config=self.cli.create_host_config(
auto_remove=False,
volumes=volumes,
mounts=target_mounts,
network_mode=self.network_mode,
shm_size=self.shm_size,
Expand Down