fix: get_cluster call project_id as self.project_id#17075
Conversation
set project_id as self.project_id from self.hook.project_id
fix: dataprocpysparkjob project_id as self.project_id
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Awesome work, congrats on your first merged pull request! |
set project_id as self.project_id from self.hook.project_id for DataprocSubmitPySparkJobOperator
as in line 1036 we are already setting value in self.project_id using this line.
self.project_id = self.hook.project_id if project_id is None else project_id
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.