Skip to content

FIX changelog provider docker 2.0.0#17008

Closed
raphaelauv wants to merge 1 commit into
apache:mainfrom
raphaelauv:patch-1
Closed

FIX changelog provider docker 2.0.0#17008
raphaelauv wants to merge 1 commit into
apache:mainfrom
raphaelauv:patch-1

Conversation

@raphaelauv

@raphaelauv raphaelauv commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

Since there is a regression in version 2.0.0 , the changelog that is directly show by the documentation ( and so the airflow website ) should let know people about.

this PR will add an option to disable the mount of the temporary directory -> #16932

Since there is a regression in version 2.0.0 , the changelog that is directly show by the documentation ( and so the airflow website ) should let know people about.
@raphaelauv

raphaelauv commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

Should I change the base branch to make this change appear on https://airflow.apache.org/docs/apache-airflow-providers-docker/2.0.0/index.htmll ?

@potiuk

potiuk commented Jul 15, 2021

Copy link
Copy Markdown
Member

This will be implemented as bugfix in 2.1.0 that willl follow. The description is also wrong. It will only fail when you have Docker-in-Docker or Remote engine, So it does not really fail always, there are a number of cases where it will continue to work.

@potiuk potiuk closed this Jul 15, 2021
@potiuk

potiuk commented Jul 15, 2021

Copy link
Copy Markdown
Member

Added in #17015

@raphaelauv

Copy link
Copy Markdown
Contributor Author

ok about the 2.1.0

but

The description is also wrong. It will only fail when you have Docker-in-Docker or Remote engine, So it does not really fail always, there are a number of cases where it will continue to work.

I wrote -> The DockerOperator mount the TemporaryDirectory 'airflowtmp/...' in all case, making fail any docker in docker usage

not that it's failing in all cases

@raphaelauv raphaelauv deleted the patch-1 branch July 15, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants