Check if we need to upgrade deps before rebuilding everything#15033
Merged
ashb merged 1 commit intoMar 26, 2021
Conversation
Due to the order of checkes in selective_ci_checks.sh, we were never eagerly upgrading deps on a Pull Reuqest, because we exited before getting to `check_if_setup_files_changed`. Previoulsy the output was this ``` Get changed files Check if everything should be run Changed files matching the ^.github/workflows/|^Dockerfile|^scripts|^setup.py|^setup.cfg pattern: Dockerfile Dockerfile.ci setup.py Important environment files changed. Running everything ... image-build=true upgrade-to-newer-dependencies=false ``` And then it exited. By simply changing the order we set the right flag _first_ and then exit.
kaxil
approved these changes
Mar 26, 2021
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
Member
Author
|
Yup, this is working now https://github.com/apache/airflow/runs/2203798051?check_suite_focus=true |
Member
|
Oh yeah 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the order of checkes in selective_ci_checks.sh, we were never
eagerly upgrading deps on a Pull Reuqest, because we exited before
getting to
check_if_setup_files_changed.Previoulsy the output was this
And then it exited. By simply changing the order we set the right flag
first and then exit.