Skip to content

Fixed failing sqlalchemy inventory.#14997

Closed
potiuk wants to merge 1 commit into
apache:masterfrom
potiuk:fix-failingsqlalchemy-docs-build
Closed

Fixed failing sqlalchemy inventory.#14997
potiuk wants to merge 1 commit into
apache:masterfrom
potiuk:fix-failingsqlalchemy-docs-build

Conversation

@potiuk

@potiuk potiuk commented Mar 25, 2021

Copy link
Copy Markdown
Member

This time sqlalchemy causes docs build failures


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

This time sqlalchemy causes docs build failures
@potiuk

potiuk commented Mar 25, 2021

Copy link
Copy Markdown
Member Author

@mik-laj - this really calls for some action - see #14989 .

@kaxil kaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the issue was with sqlalchemy, the retry and timeout was because of pymongo which also got fixed, since we fetch them in pool, it showed different error in CI.

#14986 -- this was fixed here (rebasing on Master should help). I can retrieve https://docs.sqlalchemy.org/en/latest/objects.inv

@potiuk

potiuk commented Mar 25, 2021

Copy link
Copy Markdown
Member Author

I don't think the issue was with sqlalchemy, the retry and timeout was because of pymongo which also got fixed, since we fetch them in pool, it showed different error in CI.

#14986 -- this was fixed here (rebasing on Master should help). I can retrieve https://docs.sqlalchemy.org/en/latest/objects.inv

No. it was sqlalchemy. I checked it and got infite recursion. Simply the problem was fixed in the meantime

@kaxil

kaxil commented Mar 25, 2021

Copy link
Copy Markdown
Member

I don't think the issue was with sqlalchemy, the retry and timeout was because of pymongo which also got fixed, since we fetch them in pool, it showed different error in CI.
#14986 -- this was fixed here (rebasing on Master should help). I can retrieve https://docs.sqlalchemy.org/en/latest/objects.inv

No. it was sqlalchemy. I checked it and got infite recursion. Simply the problem was fixed in the meantime

aah -- interesting -- yeah we need to make the doc build fail-safe in this kind of cases. thanks for creating the issue #14989

@potiuk potiuk closed this Mar 25, 2021
@potiuk potiuk deleted the fix-failingsqlalchemy-docs-build branch April 3, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants