Skip to content

Bump mysqlclient to support the 1.4.x and 2.x series#14978

Merged
ashb merged 2 commits into
apache:masterfrom
uranusjr:mysqlclient-15
Mar 26, 2021
Merged

Bump mysqlclient to support the 1.4.x and 2.x series#14978
ashb merged 2 commits into
apache:masterfrom
uranusjr:mysqlclient-15

Conversation

@uranusjr

Copy link
Copy Markdown
Member

Another attempt to resolve #8292.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil

kaxil commented Mar 24, 2021

Copy link
Copy Markdown
Member

Please rebase on latest Master, failing doc build should be fixed by #14986

@uranusjr uranusjr force-pushed the mysqlclient-15 branch 2 times, most recently from 1dc41b8 to 9518e3f Compare March 24, 2021 20:09
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil

kaxil commented Mar 25, 2021

Copy link
Copy Markdown
Member

Just rebased on latest Master, should fix failing issues now 🤞

@ashb

ashb commented Mar 26, 2021

Copy link
Copy Markdown
Member

@uranusjr May be worth updating the dep to <3 now actually. The only breaking change form 1.x to 2.x was removal of of py2 support https://github.com/PyMySQL/mysqlclient/blob/master/HISTORY.rst

@uranusjr

uranusjr commented Mar 26, 2021

Copy link
Copy Markdown
Member Author

Updated. I should have checked and realised 2.x is available first!

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 26, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@uranusjr uranusjr changed the title Bump mysqlclient to support the 1.4.x series Bump mysqlclient to support the 1.4.x and 2.x series Mar 26, 2021
Comment thread docs/apache-airflow-providers-mysql/index.rst
@ashb ashb merged commit fe2a70c into apache:master Mar 26, 2021
@uranusjr uranusjr deleted the mysqlclient-15 branch March 26, 2021 18:59
@ashb

ashb commented Mar 26, 2021

Copy link
Copy Markdown
Member

A bug in our CI might have meant that these tests were run against the old dep, and as a result one of the GCS tests fails because it tried to do:

from _mysql_exceptions import ProgrammingError

Fix coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump supported mysqlclient to <1.5

4 participants